WebGLPrograms: sheen and transmission checks clean up. #25723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
commented
Mar 28, 2023
|
|
||
| transmission: useTransmission, | ||
| transmissionMap: useTransmission && !! material.transmissionMap, | ||
| thicknessMap: useTransmission && !! material.thicknessMap, |
Owner
Author
There was a problem hiding this comment.
Is thicknessMap used when transmission is not used?
Contributor
There was a problem hiding this comment.
At least in glTF "thicknessMap" comes from the volume extension that requires the transmission extension.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
mrdoob
changed the title
Mugen87
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #25721
Description
Another clean up while working on #25721.