I remember you guys were so tight about undefined/null issues, should you not be fixing this here instead?

The null check seems to be fine?

https://github.com/mrdoob/three.js/blob/dev/src/textures/Source.js#L6

If anything, the undefined check should be needed?

Yeah, I think this comes from a time when we used undefined as the default image value.

a time when we used undefined

ah so it is null now, btw why did you switch? was undefined causing problems?

Using null as a default value is just more robust then undefined.

Using null as a default value is just more robust then undefined.

I have found the patient zero of this... line of thought - it was @stephomi, 10 years ago 👈