-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
NodeEditor: New Version (Rev. 3) #25692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is awesome!!!
This partially resolves #25256 (ScriptableNode allows working with JS nodes similar to how CodeNode allows that for GLSL and WGSL nodes). I will start working on a PR adding JS as a possible output language (like GLSL or WGSL), i.e. JSNodeBuilder (and maybe also CPURenderer similar to the removed SoftwareRenderer) sometime soon... |
|
@LeviPesin I see a very promising future :) |
|
Getting zbuffer issues on a M1. Is there a way to change the camera near/far? Screen.Recording.2023-03-21.at.15.39.30.mov |
|
Seems like the selections in monaco do not work properly when changing the zoom level? Screen.Recording.2023-03-21.at.15.51.13.mov |
|
What do you think about moving this editor (and related code) to it's own folder in the root of the repo? |
| constructor( target = null ) { | ||
|
|
||
| } | ||
| super( 'context', target ); |
Check warning
Code scanning / CodeQL
Superfluous trailing arguments
| constructor( target = null ) { | ||
|
|
||
| dom.onchange = () => { | ||
| super( 'circle', target ); |
Check warning
Code scanning / CodeQL
Superfluous trailing arguments
|
Please add |
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|

I'll make this description as the days go by, but I have to say, I've never been as excited to finish a PR as this one. Many improvements have been made, and we have full integration with TSL ( Three.js Shading Language ) and finally support for CPU Nodes.
Tested on Google Chrome
WebGL
https://raw.githack.com/sunag/three.js/dev-just-nodes/playground/
WebGPU
https://raw.githack.com/sunag/three.js/dev-just-nodes/playground/?backend=webgpu
Scene entirely created using NodeEditor.
/cc @mrdoob @bhouston
Now we can create nodes for interactivity purposes.