UniformsUtils: Skip cloning textures of render targets and report warning. #25560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Mugen87
reviewed
Feb 24, 2023
Mugen87
reviewed
Feb 24, 2023
Mugen87
reviewed
Feb 24, 2023
Mugen87
changed the title
Mugen87
changed the title
epreston
reviewed
Feb 24, 2023
Contributor
Author
|
Hey, sorry about sitting on this, I was away from the computer for a few days! Thanks for taking this over the line. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #25552.
Description
Render Target Textures can't be cloned, do a check in UniformsUtils.cloneUniforms to avoid this, and output a warning to console. Also updated docs with example usage, and unit tests.