WebGPURenderer: Added VideoTexture support #25530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
LeviPesin
reviewed
Feb 19, 2023
|
|
||
| } else { | ||
|
|
||
| console.error( 'WebGPURenderer: THREE.VideoTexture does not support vertex shader.' ); |
Contributor
There was a problem hiding this comment.
Does it support compute shader?
LeviPesin
reviewed
Mar 28, 2023
|
|
||
| if ( this.defaultVideoTexture === null ) { | ||
|
|
||
| const video = document.getElementById( 'video' ); |
Contributor
There was a problem hiding this comment.
I think we should do something like this here:
const video = typeof document !== 'undefined' ? document.createElement( 'video' ) : null;
Collaborator
Author
There was a problem hiding this comment.
Hmm... My first attempt was just put THREE.VideoTexture() but it crashes here:
three.js/src/textures/VideoTexture.js
Line 26 in 2745552
and maybe should crashes using device.importExternalTexture() too without <video>.
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Live:
https://raw.githack.com/sunag/three.js/webgpu-video-texture/examples/webgpu_materials_video.html