WebGLRenderer: Fixed vertex attributes update with InstancedMesh. #19015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Wouldn't this update things unneededly when rendering a single |
Collaborator
Author
|
This happens anyway since all |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed https://discourse.threejs.org/t/reusing-instancedmesh-geometry-and-material/14008/.
When two or more
InstancedMeshshare the same geometry, it's still necessary to refresh the vertex attributes viasetupVertexAttributes(). That is necessary since the vertex data not only depend on the used geometry and material but also on the 3D object (instanceMatrix).Hence, it's safe to always call
setupVertexAttributes()when anInstancedMeshis going to be rendered otherwiseinstanceMatrixmight have a wrong buffer binding.