DragControls: Add support for dragging a group object. #18623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I think the example is confusing. What about adding something like "shift+click" to add to the selection in this example? |
Collaborator
Author
You're right, that makes the handling more clear. Let me update the PR... |
Collaborator
Author
|
Okay, I've enhanced |
Owner
|
Much nicer! |
Collaborator
Author
|
Done! Also clarified the description at the header. |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small enhancement to
DragControls. It allows users to drag a group instead of the individual 3D objects. I've seen this feature request multiple times in the past and I thought it's a good addition to the controls (e.g. https://discourse.threejs.org/t/dragcontrol-for-a-group-object/12645).The idea is to expose the array of draggable objects and introduce a new boolean property that enables the new behavior. I've enhanced
webgl_loader_3mf_materialsto shows this new feature. It's now possible to drag the entire truck and not its individual parts.