Material shader extensions #14231
Material shader extensions #14231
Conversation
pailhead
force-pushed
the
material-shader-extension-clean
branch
from
24a6494 to
21900cd
Compare
pailhead
force-pushed
the
material-shader-extension-clean
branch
from
21900cd to
088a2ee
Compare
pailhead
changed the title
|
This proposal and all the ones before it should, under no circumstances be used to add features to the library.
The only code that this PR should ever add to three.js from here to eternity is the code for itself. It should never ever directly be used to add a feature to the library. It is by itself a feature of the library, and it should never ever go past that. It should only be used by users to add features to their applications. I hope this clarifies years of confusion. :) I'll try to write this more legalese. I've used the This is conceptually totally different from ping @mrdoob ping @donmccurdy |
2 participants
A proposal that allows an alternate approach to extending built-in materials. Only the core change is present in this PR.
Some examples are made in #14206, click on the images to see the demos.
Use this API in
GLTFLoaderto extend theStandardMaterialwith spec/gloss model. And then in the actual loader example, make an "inline" extension for simple instancing (instancing_lambertexample). The goal is to have two completely agnostic extensions that just work together - the instancing is applied to an arbitrary material, while the spec/gloss is intended solely forStandardMaterial.Combine three different extensions (simple instancing, per map uv channels and spec/gloss) on a single material, and modify one of the extensions "inline" (use the instancing offset, but animate the scale effect in the shader). The demo uses a refactored GLTFLoader that just calls one of these decorators, the rest are applied in the inline demo code.
Individually these can be done with
onBeforeCompile, butonBeforeCompilemay possibly have issues. The name might be better asonBeforeParseoronWillRefresh. Combining these is a challenge with it though, while this API may be more flexible, if not the friendliest one.Per map transforms with
onBeforeCompile.Instancing lambert refactored with
onBeforeCompileStandard/gloss refactor with
onBeforeCompile.This should be decoupled from
/examples/nodesand not be blocked by it. Thank you.