Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Shader Chunk includes broken since THREEjs v. 138 #23580

Closed
jocabola opened this issue Feb 24, 2022 · 4 comments
Closed

Custom Shader Chunk includes broken since THREEjs v. 138 #23580

jocabola opened this issue Feb 24, 2022 · 4 comments

Comments

@jocabola
Copy link
Contributor

jocabola commented Feb 24, 2022 •
edited by mrdoob
Loading

Hello there!

I have upgraded one project to latest THREEjs 138, and suddenly all my custom shader chunk includes no longer work.

This is what I would usually do:

import noise3D from '../../glsl/lib/snoise3D.glsl';
import noise4D from '../../glsl/lib/snoise4D.glsl';

ShaderChunk['noise3D'] = noise3D;
ShaderChunk['noise4D'] = noise4D;

Then have #include <noise4D> in my shader for example.

This causes a JS error in includeReplacer since v. 138. See screenshot below:

image

THANKS!
@mrdoob
Copy link
Owner

mrdoob commented Feb 24, 2022

That is strange, I don't think we have changed anything around that between r137 and r138 🤔

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 25, 2022 •
edited
Loading

I have upgraded one project to latest THREEjs 138

From what release have you performed the upgrade?

In any event, please share an editable live example that demonstrates the issue.

@jocabola
Copy link
Contributor Author

I was upgrading from v 137.5 to 138. I can't share this example precisely cause it's a WIP client project but will look at creating an isolated example and see. I use 11ty, esbuild and TypeScript as my "boilerplate". Will create a sample and share. Thanks!

@jocabola
Copy link
Contributor Author

OK, I have isolated this scenario into a "clean" test and I no longer get the error happening. There must be another reason why this is happening to me in my other project when upgrading from 137.5 to 138. Will investigate.

Sorry for the confusion and thanks for your time!

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrdoob @jocabola @Mugen87