dftbplus: backport "Fix logic for OMP target in exported dftbplus-config.cmake"#23
Closed
hmenke wants to merge 1 commit intompsd-computational-science:mpsd/v0.23_25afrom
Closed
dftbplus: backport "Fix logic for OMP target in exported dftbplus-config.cmake"#23hmenke wants to merge 1 commit intompsd-computational-science:mpsd/v0.23_25afrom
hmenke wants to merge 1 commit intompsd-computational-science:mpsd/v0.23_25afrom
Conversation
|
We should also push that to spack upstream. Do you want to do that or shall I? |
Author
|
Feel free to try to upstream this to Spack. You'll need to check the |
lang-m
added a commit
that referenced
this pull request
May 19, 2025
…fig.cmake" Closes #23 Co-authored-by: Henri Menke <[email protected]>
|
Thanks Henri! I have added this directly to the v0.23_25a branch because it required some changes (diff/patch urls from github need an additional parameter to get full commit hashes, which in turn also changes the checksum) and it was easier to just do this myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in https://gitlab.com/octopus-code/octopus/-/issues/1253