Propagate nan in ei_asymp()#672
Merged
Merged
Conversation
Closes mpmath#480 Closes mpmath#481 Closes mpmath#482 Closes mpmath#483 Closes mpmath#484 Closes mpmath#487
cbm755
approved these changes
Mar 29, 2023
skirpichev
commented
Mar 29, 2023
| k += 1 | ||
| t *= k*r | ||
| s += t | ||
| if abs(t) < 1e-16: |
Collaborator
Author
There was a problem hiding this comment.
Or
diff --git a/mpmath/math2.py b/mpmath/math2.py
index 302e25f..e54c0d1 100644
--- a/mpmath/math2.py
+++ b/mpmath/math2.py
@@ -507,7 +507,7 @@ def ei_asymp(z, _e1=False):
while 1:
t *= k*r
s += t
- if abs(t) < 1e-16:
+ if not (abs(t) >= 1e-16):
break
k += 1
v = s*exp(z)/z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #480
Closes #481
Closes #482
Closes #483
Closes #484
Closes #487