Don't use setuptools_scm: revert to manual version management#586
Merged
Conversation
This was referenced Mar 26, 2021
|
This looks like a great solution! 👍 |
Collaborator
Author
|
I'm not so sure. |
|
Agreed, I think this fixes this issue. FWIW I tag-on-release using a Github action which works pretty well. |
Collaborator
Author
|
Should work too, why not. Not sure if it's possible to sign such a tag, however. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setuptools_scm usage was broken by 867d878 (likely,
this is a source of problem in #585)
Closes #580 (an alternative to #583 and #581)
Solves #585 as well.