Skip to content

Get version from __init__#581

Closed
mikedh wants to merge 1 commit into
mpmath:masterfrom
mikedh:master
Closed

Get version from __init__#581
mikedh wants to merge 1 commit into
mpmath:masterfrom
mikedh:master

Conversation

@mikedh

@mikedh mikedh commented Mar 18, 2021

Copy link
Copy Markdown

Attempt to fix #580. Gets version for setup from __init__.py to prevent duplication of version, and removes dependency on setuptools_scm.

This is how many/most projects handle version; I'm not sure how mixing most data from setup.cfg with the version in setup.py works. Although in testing with pip install -e locally it worked fine.

@skirpichev

Copy link
Copy Markdown
Collaborator

I think, much simpler solution is to pin required deps (that may be a conditional pin, only for py2), until we not drop support for py2 as others. No need to reinvent wheel.

@asmeurer

Copy link
Copy Markdown
Contributor

+1 for removing setuptools_scm.

@mikedh

mikedh commented Mar 26, 2021

Copy link
Copy Markdown
Author

I guess I don't know the full context of why one would want setuptools_scm From my perspective, it is a narrowly used package with a very casual attitude towards breaking things upstream ("just upgrade your pip"). I don't use Python 2, but I respect that somewhere between 5-10% of people do for various reasons, and my plan was to keep libraries I maintain installable on Python 2 until the wheels really fall off 😄.

That being said, I dropped sympy from Python 2 installs for this issue, so I no longer have a duck in this race and am I fine with whatever! There was some indications in that thread that pinning setuptools_scm version did not help until pip was upgraded (which happens in current mpmath builds so it's hard to say).

@skirpichev

Copy link
Copy Markdown
Collaborator

From my perspective, it is a narrowly used package with a very casual attitude towards breaking things upstream ("just upgrade your pip")

Looking on the thread, this seems to be an issue with very old pip versions. The Debian Stretch has something like this.

@mikedh mikedh closed this Mar 26, 2021
t98yu pushed a commit to HPQC-LABS/mpmath that referenced this pull request Apr 26, 2021
The setuptools_scm usage was broken by 867d878 (likely,
this is a source of problem in mpmath#585)

Closes mpmath#580 (an alternative to mpmath#583 and mpmath#581)
Solves mpmath#585 as well.
t98yu pushed a commit to t98yu/mpmath that referenced this pull request Apr 27, 2021
The setuptools_scm usage was broken by 867d878 (likely,
this is a source of problem in mpmath#585)

Closes mpmath#580 (an alternative to mpmath#583 and mpmath#581)
Solves mpmath#585 as well.
t98yu pushed a commit to t98yu/mpmath that referenced this pull request Apr 27, 2021
The setuptools_scm usage was broken by 867d878 (likely,
this is a source of problem in mpmath#585)

Closes mpmath#580 (an alternative to mpmath#583 and mpmath#581)
Solves mpmath#585 as well.
t98yu pushed a commit to t98yu/mpmath that referenced this pull request Apr 28, 2021
The setuptools_scm usage was broken by 867d878 (likely,
this is a source of problem in mpmath#585)

Closes mpmath#580 (an alternative to mpmath#583 and mpmath#581)
Solves mpmath#585 as well.
t98yu pushed a commit to t98yu/mpmath that referenced this pull request Apr 28, 2021
The setuptools_scm usage was broken by 867d878 (likely,
this is a source of problem in mpmath#585)

Closes mpmath#580 (an alternative to mpmath#583 and mpmath#581)
Solves mpmath#585 as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setuptools_scm dropped Python 2 breaking install

3 participants