Fix #1003: sinm and cosm can accept list as arguments, similar to expm and other functions#1006
Merged
Merged
Conversation
skirpichev
approved these changes
Oct 8, 2025
skirpichev
left a comment
skirpichev
left a comment
Collaborator
There was a problem hiding this comment.
I came across a very subtle problem, that when the input matrix to expm(), cosm() and sinm() is a non-square matrix, the error is thrown from the expm()
I think that is fine.
That part was reverted and tests slightly simplified. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sinm()andcosm()don't accept list or int arguments. #1003expm(),cosm()andsinm()is a non-square matrix, the error is thrown from theexpm()when it calls the__pow__()inside it, which is not very readable and also exposes the inner working ofexpm(). I have fixed this too, by having a separate check for non-square matrix.