Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

For #26093: Use ic_menu instead of ic_close#26707

Merged
rvandermeulen merged 1 commit intomozilla-mobile:mainfrom
Mugurell:runCiFor26705
Aug 30, 2022
Merged

For #26093: Use ic_menu instead of ic_close#26707
rvandermeulen merged 1 commit intomozilla-mobile:mainfrom
Mugurell:runCiFor26705

Conversation

@Mugurell
Copy link
Contributor

@Mugurell Mugurell commented Aug 30, 2022 •
edited by github-actions bot
Loading

Run CI for #26705

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #26093

@czlucius
For mozilla-mobile#26093: Use ic_menu instead of ic_close
24980be 
An override for History already exists in `HistoryListItemViewHolder`, so no global override for this icon is needed.
@Mugurell Mugurell requested review from a team as code owners August 30, 2022 07:12
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2022

⚠️ The sha of the head commit of this PR conflicts with #26705. Mergify cannot evaluate rules on this PR. ⚠️

@Mugurell
Copy link
Contributor Author

Mugurell commented Aug 30, 2022

complete-pr seems to not have ran on the original PR.
Trying to restart the tasks.

@Mugurell Mugurell closed this Aug 30, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2022

⚠️ The sha of the head commit of this PR conflicts with #26705. Mergify cannot evaluate rules on this PR. ⚠️

@Mugurell Mugurell reopened this Aug 30, 2022
@Mugurell Mugurell added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Aug 30, 2022
@rvandermeulen rvandermeulen merged commit d26642b into mozilla-mobile:main Aug 30, 2022
@Mugurell Mugurell deleted the runCiFor26705 branch August 30, 2022 14:20
@rvandermeulen rvandermeulen mentioned this pull request Aug 30, 2022
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

pr:needs-landing PRs that are ready to land [Will be merged by Mergify]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: 3 dot menu icons in Bookmarks are displayed as close ("X") icons

3 participants

@Mugurell @rvandermeulen @czlucius