This repository was archived by the owner on Feb 20, 2023. It is now read-only.
For #26093: Use ic_menu instead of ic_close#26705
Closed
czlucius wants to merge 2 commits intomozilla-mobile:mainfrom
Closed
For #26093: Use ic_menu instead of ic_close#26705czlucius wants to merge 2 commits intomozilla-mobile:mainfrom
ic_menu instead of ic_close#26705czlucius wants to merge 2 commits intomozilla-mobile:mainfrom
Conversation
An override for History already exists in `HistoryListItemViewHolder`, so no global override for this icon is needed.
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
Mugurell
approved these changes
Aug 30, 2022
Contributor
Mugurell
left a comment
Mugurell
left a comment
There was a problem hiding this comment.
LGTM!
Thank you!
Will help land.
4 tasks
Mugurell
added
the
pr:needs-landing
Mugurell
removed
the
pr:needs-landing
Contributor
|
Landed in #26707. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for #26093
Pull Request checklist
Screenshots of the fix:
QA
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-debugtask.View task in Taskclusterin the newDETAILSsection.GitHub Automation
Fixes #26093