Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

CI for contributor PR - 20486#20831

Merged
mergify[bot] merged 2 commits intomozilla-mobile:mainfrom
Mugurell:CIFor20486
Sep 2, 2021
Merged

CI for contributor PR - 20486#20831
mergify[bot] merged 2 commits intomozilla-mobile:mainfrom
Mugurell:CIFor20486

Conversation

@Mugurell
Copy link
Contributor

@Mugurell Mugurell commented Aug 13, 2021

Run CI for contributor PR - #20486

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Mugurell Mugurell requested review from a team as code owners August 13, 2021 09:31
@Mugurell
Copy link
Contributor Author

Mugurell commented Aug 13, 2021

org.mozilla.fenix.ui.NavigationToolbarTest > visitURLTest[test(AVD) - 9] FAILED
Trying one more time.

@Mugurell Mugurell closed this Aug 13, 2021
@Mugurell Mugurell reopened this Aug 13, 2021
@Mugurell
Copy link
Contributor Author

Mugurell commented Aug 18, 2021

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2021

Command rebase: success

Branch has been successfully rebased

@Mugurell
Copy link
Contributor Author

Mugurell commented Aug 18, 2021

@Mergifyio squash first-commit

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2021

Command squash first-commit: success

Pull request squashed successfully

@Mugurell
Copy link
Contributor Author

Mugurell commented Sep 1, 2021

Seems like an intermittent test failure in test-debug for WebPushEngineIntegrationTest#delegate calls getSubscription.

java.lang.InstantiationError: kotlin.jvm.functions.Function1
...
at org.mozilla.fenix.push.WebPushEngineIntegrationTest$delegate calls getSubscription$1.invoke(WebPushEngineIntegrationTest.kt:223)
at org.mozilla.fenix.push.WebPushEngineIntegrationTest$delegate calls getSubscription$1.invoke(WebPushEngineIntegrationTest.kt:96)

Restarting CI.

@Mugurell Mugurell closed this Sep 1, 2021
@Mugurell Mugurell reopened this Sep 1, 2021
codrut-topliceanu
codrut-topliceanu approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@codrut-topliceanu codrut-topliceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Mugurell Mugurell added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Sep 1, 2021
@mergify mergify bot merged commit cb67412 into mozilla-mobile:main Sep 2, 2021
@Mugurell Mugurell deleted the CIFor20486 branch September 2, 2021 11:25
@Mugurell Mugurell mentioned this pull request Sep 2, 2021
Closed
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@codrut-topliceanu codrut-topliceanu codrut-topliceanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr:needs-landing PRs that are ready to land [Will be merged by Mergify]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mugurell @codrut-topliceanu @czlucius