refactor: Convert server.rs to use async await#945
Closed
Marwes wants to merge 1 commit intomozilla:masterfrom
Closed
refactor: Convert server.rs to use async await#945Marwes wants to merge 1 commit intomozilla:masterfrom
Marwes wants to merge 1 commit intomozilla:masterfrom
Conversation
Collaborator
|
Note that we have a full migration for the all of sccache (besides the tests) compiling - see #946 / https://github.com/paritytech/sccache/pull/31which we intend to upstream. |
mitchhentges
approved these changes
Feb 5, 2021
Contributor
mitchhentges
left a comment
mitchhentges
left a comment
There was a problem hiding this comment.
Neat! Looks good, though you'll want to have a full sign-off by glandium.
Also heads up that there's some clippy notes in CI that are worth resolving 👍
| env.as_slice(), | ||
| &me.pool, | ||
| dist_info.clone().map(|(p, _)| p), | ||
| match opt { |
Contributor
There was a problem hiding this comment.
Neat simplification around w_fallback 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #787 . I believe I fixed all nits in the review.