Import std::task::Context as Context again#792
Merged
glandium merged 1 commit intomozilla:masterfrom Jun 11, 2020
Merged
Conversation
We shouldn't contort and rename structs for the purpose of some trait whose name doesn't matter in practice.
nnethercote
approved these changes
Jun 11, 2020
| use crate::mock_command::{CommandCreatorSync, ProcessCommandCreator}; | ||
| use crate::protocol::{Compile, CompileFinished, CompileResponse, Request, Response}; | ||
| use crate::util; | ||
| use anyhow::Context as _; |
Contributor
There was a problem hiding this comment.
Cool, I didn't know that was a thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't contort and rename structs for the purpose of some trait
whose name doesn't matter in practice.