Skip to content

add support for clippy-driver to sccache#728

Merged
froydnj merged 1 commit intomozilla:masterfrom
yaahc:master
May 6, 2020
Merged

add support for clippy-driver to sccache#728
froydnj merged 1 commit intomozilla:masterfrom
yaahc:master

Conversation

@yaahc
Copy link
Copy Markdown
Contributor

@yaahc yaahc commented Apr 23, 2020

@yaahc
Copy link
Copy Markdown
Contributor Author

yaahc commented Apr 23, 2020

This is admittedly not a great solution, with this approach every single binary that wants to work as a RUSTC_WORKSPACE_WRAPPER and sccache will need to be added to this list. Long term I expect this should be changed to detect rustc without ever checking the name of the binary, I wouldn't mind doing that as part of this PR but I didn't want to spend the time exploring sccache enough to be confident in my changes beyond this minimal fix.

@froydnj froydnj merged commit f502075 into mozilla:master May 6, 2020
@froydnj
Copy link
Copy Markdown
Contributor

froydnj commented May 6, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--fix fails sometimes if clippy and sccache used: "error: Unrecognized option: \'E\'\n\n

2 participants