feat: support for Tencent Cloud Object Storage by RinChanNOWWW · Pull Request #2563 · mozilla/sccache

RinChanNOWWW · 2026-01-18T05:44:20Z

Support for Tencent Cloud Object Storage.

docs/Configuration.md

.gitignore

docs/COS.md

codecov-commenter · 2026-01-18T09:48:44Z

Codecov Report

❌ Patch coverage is 36.00000% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.18%. Comparing base (d9d2eb6) to head (1742fa4).
⚠️ Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
src/cache/cache.rs	0.00%	12 Missing ⚠️
src/cache/cos.rs	0.00%	11 Missing ⚠️
src/config.rs	60.86%	9 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2563   +/-   ##
=======================================
  Coverage   71.18%   71.18%           
=======================================
  Files          64       65    +1     
  Lines       35588    35669   +81     
=======================================
+ Hits        25333    25392   +59     
- Misses      10255    10277   +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

src/config.rs

sylvestre · 2026-01-18T09:51:28Z

src/config.rs

    }

+    // ======= COS =======
+    let cos = if let Ok(bucket) = env::var("SCCACHE_COS_BUCKET") {


Missing validation: SCCACHE_COS_ENDPOINT should be required when SCCACHE_COS_BUCKET is set. Add validation like: if env::var('SCCACHE_COS_BUCKET').is_ok() && env::var('SCCACHE_COS_ENDPOINT').is_err() { bail!('SCCACHE_COS_ENDPOINT must be set'); }

I followed the codes of other object stores (like OSS). They don't validate the Option but declare the endpoint as a necessary (must) configuration.

Impl for COS.

6492ef8