Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.17%. Comparing base (898254e) to head (46f5579).

@@            Coverage Diff             @@
##             main    #2545      +/-   ##
==========================================
- Coverage   71.18%   71.17%   -0.01%     
==========================================
  Files          64       64              
  Lines       35575    35588      +13     
==========================================
+ Hits        25324    25331       +7     
- Misses      10251    10257       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

silly question but is there really a need for this ?

silly question but is there really a need for this ?

Yes. OpenSSL, for example, uses the same executable for building both asm and C sources. So, if we want to use the same wrapper for OpenSSL - we need to have support assembly too.

P.S. ccache also supports asm, see https://ccache.dev/platform-compiler-language-support.html

Merging this PR will not alter performance

✅ 11 untouched benchmarks

_{Comparing AJIOB:asm-support (46f5579) with main (898254e)}