Skip to content

Comments

msvc: fix detect_showincludes_prefix with MSBuild#2544

Merged
sylvestre merged 2 commits intomozilla:mainfrom
AJIOB:VS_UNICODE_OUTPUT_fix_2
Jan 13, 2026
Merged

msvc: fix detect_showincludes_prefix with MSBuild#2544
sylvestre merged 2 commits intomozilla:mainfrom
AJIOB:VS_UNICODE_OUTPUT_fix_2

Conversation

@AJIOB
Copy link
Contributor

@AJIOB AJIOB commented Jan 8, 2026

The problem usually occurs when VS_UNICODE_OUTPUT is set. This is a @AudranDoublet #1835 and @exoosh #2483 fixes with working tests: thank you!

Should fix issues #1830 and #909

@AJIOB AJIOB force-pushed the VS_UNICODE_OUTPUT_fix_2 branch from 0e300e6 to edde193 Compare January 8, 2026 07:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.24%. Comparing base (bbb8440) to head (a34b52a).

Files with missing lines Patch % Lines
src/compiler/msvc.rs 72.72% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2544   +/-   ##
=======================================
  Coverage   71.23%   71.24%           
=======================================
  Files          64       64           
  Lines       35597    35593    -4     
=======================================
- Hits        25359    25357    -2     
+ Misses      10238    10236    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 10, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing AJIOB:VS_UNICODE_OUTPUT_fix_2 (a34b52a) with main (bbb8440)

Summary

✅ 27 untouched benchmarks
🆕 27 new benchmarks
⏩ 2 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
🆕 Memory cache_entry_batch_roundtrip N/A 3.5 MB N/A
🆕 Memory build_workflow_initial N/A 3.5 MB N/A
🆕 Memory lru_cache_eviction N/A 186.1 KB N/A
🆕 Memory lru_cache_insert N/A 372.1 KB N/A
🆕 Memory lru_hotcold_access_pattern N/A 128 B N/A
🆕 Memory cache_entry_roundtrip_small N/A 3.5 MB N/A
🆕 Memory time_macro_finder_no_macros N/A 192 B N/A
🆕 Memory hash_header_file N/A 192 B N/A
🆕 Memory decompression_high_ratio N/A 3.3 MB N/A
🆕 Memory cache_entry_create_large N/A 3.5 MB N/A
🆕 Memory build_workflow_rebuild N/A 2.9 MB N/A
🆕 Memory cache_entry_roundtrip_large N/A 4.3 MB N/A
🆕 Memory time_macro_finder_with_macros N/A 192 B N/A
🆕 Memory hash_large_data N/A 192 B N/A
🆕 Memory cache_key_generation N/A 192 B N/A
🆕 Memory lru_cache_mixed_workload N/A 222 KB N/A
🆕 Memory hash_multiple_files N/A 128 B N/A
🆕 Memory cache_entry_create_small N/A 3.5 MB N/A
🆕 Memory lru_realistic_eviction_pressure N/A 4.9 MB N/A
🆕 Memory cache_entry_batch_create N/A 3.5 MB N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sylvestre
Copy link
Collaborator

sylvestre commented Jan 11, 2026

could you please add a test to make sure we don't regress? thanks

@AJIOB AJIOB force-pushed the VS_UNICODE_OUTPUT_fix_2 branch 3 times, most recently from 7b70bc7 to 4f1f083 Compare January 12, 2026 08:12
@AJIOB
Copy link
Contributor Author

AJIOB commented Jan 12, 2026

could you please add a test to make sure we don't regress? thanks

@sylvestre , done

@sylvestre
Copy link
Collaborator

sylvestre commented Jan 12, 2026

could you please add a test to make sure we don't regress? thanks

@sylvestre , done

to make sure i understand, what you added in the CI was previously failing to build, right ?
thanks

@AJIOB
Copy link
Contributor Author

AJIOB commented Jan 12, 2026

Yes, it previously fails.

sylvestre
sylvestre reviewed Jan 13, 2026
View reviewed changes
sylvestre
sylvestre reviewed Jan 13, 2026
View reviewed changes
@AJIOB AJIOB force-pushed the VS_UNICODE_OUTPUT_fix_2 branch from 4f1f083 to 12828e0 Compare January 13, 2026 14:02
Audran Doublet and others added 2 commits January 13, 2026 17:30
@AJIOB
msvc: fix detect_showincludes_prefix with MSBuild
c07b3d8 
The problem usually occurs when VS_UNICODE_OUTPUT is set.
This is a @AudranDoublet mozilla#1835 and @exoosh mozilla#2483 fixes with working tests: thank you!

Should fix issues mozilla#1830 and mozilla#909
@AJIOB
msvc: add msbuild support test
a34b52a
@AJIOB AJIOB force-pushed the VS_UNICODE_OUTPUT_fix_2 branch from 12828e0 to a34b52a Compare January 13, 2026 14:30
@AJIOB AJIOB requested a review from sylvestre January 13, 2026 15:22
@sylvestre sylvestre merged commit d616437 into mozilla:main Jan 13, 2026
57 checks passed
@AJIOB AJIOB deleted the VS_UNICODE_OUTPUT_fix_2 branch January 13, 2026 15:34
This was referenced Jan 13, 2026
Closed
Open
@BrewTestBot BrewTestBot mentioned this pull request Jan 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AJIOB @codecov-commenter @sylvestre