Switch from the unmaintained daemonize crate to a maintained fork#2500
Merged
sylvestre merged 2 commits intomozilla:mainfrom Dec 17, 2025
Merged
Switch from the unmaintained daemonize crate to a maintained fork#2500sylvestre merged 2 commits intomozilla:mainfrom
sylvestre merged 2 commits intomozilla:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2500 +/- ##
==========================================
- Coverage 71.05% 71.05% -0.01%
==========================================
Files 64 64
Lines 35359 35359
==========================================
- Hits 25124 25123 -1
- Misses 10235 10236 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daemonize crate was marked as unmaintained. It also has a potential UB issue, though as far as I can tell, sccache does not use the crate in a way that would trigger the problem.
This PR switches the dependency to a maintained fork (maintained by me) where that UB issue was resolved in a published version.
c.f. https://rustsec.org/advisories/RUSTSEC-2025-0069.html