msvc: handle '/FoRelease\' command-line argument#2482
Merged
sylvestre merged 1 commit intomozilla:mainfrom Nov 12, 2025
Merged
Conversation
MSBuild may provide as output file (/Fo) plus a folder ending with a
trailing backslash, for example /FoRelease\.
msvc detects this case and chooses {folder}/{input_file_name}.obj as
output file. For example, for /cfoo.c /FoRelease\, the expected output
path (by linker and msbuild) is Release/foo.obj.
Fixes mozilla#1687 mozilla#1844.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
=======================================
Coverage 71.14% 71.15%
=======================================
Files 64 64
Lines 35207 35242 +35
=======================================
+ Hits 25047 25075 +28
- Misses 10160 10167 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I think codecov is confused. The lines it's reporting as uncovered, are lines inside the test. |
Contributor
|
I tested this and it works great. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSBuild may provide as output file (/Fo) plus a folder ending with a trailing backslash, for example /FoRelease.
msvc detects this case and chooses {folder}/{input_file_name}.obj as output file. For example, for /cfoo.c /FoRelease, the expected output path (by linker and msbuild) is Release/foo.obj.
Fixes #1687 #1844.
Edit: This pull request is basically #1836 rebased and changed minimally to pass all tests. The changes are:
The "author" header in the commit preserves the author of the original pull request.