Skip to content

Comments

Use generator in CMAKE_MSVC_DEBUG_INFORMATION_FORMAT in README#2479

Merged
sylvestre merged 1 commit intomozilla:mainfrom
Andrej730:msvc_debug_format_generator
Nov 10, 2025
Merged

Use generator in CMAKE_MSVC_DEBUG_INFORMATION_FORMAT in README#2479
sylvestre merged 1 commit intomozilla:mainfrom
Andrej730:msvc_debug_format_generator

Conversation

@Andrej730
Copy link
Contributor

@Andrej730 Andrej730 commented Nov 5, 2025

As it is probably the recommended way to do integrate cache in cmake, without introducing unexpected debug symbols to Release / MinSizeRel builds.

Also consistent with the usage described in the official docs - https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_DEBUG_INFORMATION_FORMAT.html

@Andrej730
Copy link
Contributor Author

@sylvestre can you please take a look at that one too? 😅

As it is probably the recommended way to do integrate cache in cmake, without introducing unexpected debug symbols to Release / MinSizeRel build.
Also consistent with the usage described in the official docs - https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_DEBUG_INFORMATION_FORMAT.html
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.14%. Comparing base (9a24b6f) to head (e0efcde).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2479   +/-   ##
=======================================
  Coverage   71.14%   71.14%           
=======================================
  Files          64       64           
  Lines       35207    35207           
=======================================
  Hits        25047    25047           
  Misses      10160    10160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvestre sylvestre merged commit 62777c8 into mozilla:main Nov 10, 2025
55 checks passed
@Andrej730 Andrej730 deleted the msvc_debug_format_generator branch November 10, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants