Don't run tests using Clang as CUDA compiler on Windows#2444
Don't run tests using Clang as CUDA compiler on Windows#2444sylvestre merged 2 commits intomozilla:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2444 +/- ##
==========================================
+ Coverage 70.94% 71.41% +0.46%
==========================================
Files 65 65
Lines 35535 36229 +694
==========================================
+ Hits 25211 25872 +661
- Misses 10324 10357 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Visual Studio 2022 ships MVSC 14 and Clang 19. The problem with CUDA is that there is no version that works with both MSVC 14 and Clang 19, so the CUDA / Clang test always failed.
ahartmetz
force-pushed
the
windows_no_cuda_clang
branch
from
bfca905 to
c744502
Compare
|
Another option would be to disable the CUDA / Clang test if an environment variable is set, and set it in appropriate CI configurations. It might work again with the next Visual Studio release. Or install current Clang in the CI, obviously, but that seems like a chore and would also increase CI runtime. At least (I didn't know and it was kind of hard to find) LLVM does seem to provide binary downloads for Windows, e.g.: https://github.com/llvm/llvm-project/releases/tag/llvmorg-21.1.0 |
ahartmetz
force-pushed
the
windows_no_cuda_clang
branch
2 times, most recently
from
fb83e62 to
a973056
Compare
(or anyone running the tests, using environment variable NOTEST_CUDA_COMPILERS)
ahartmetz
force-pushed
the
windows_no_cuda_clang
branch
from
a973056 to
5474a88
Compare
|
@trxcllnt ok with you ? :) |
|
That string list filtering code that I've written seems rather verbose btw, any tips for doing better? |
3 participants
Visual Studio 2022 actually ships Clang these days. The included Clang v19 is too old to work with CUDA versions new enough to work with the MVSC version 14 also included with VS2022.