Fix symbolic links to sccache on Linux#2439
Merged
sylvestre merged 4 commits intomozilla:mainfrom Sep 21, 2025
Merged
Conversation
ahartmetz
force-pushed
the
symlink
branch
2 times, most recently
from
d620592 to
8677f1c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2439 +/- ##
==========================================
+ Coverage 71.42% 71.45% +0.02%
==========================================
Files 65 65
Lines 36229 36270 +41
==========================================
+ Hits 25877 25915 +38
- Misses 10352 10355 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Whether or not env::current_exe follows symlinks is platform dependant. On linux it follows them which made it impossible to do things like ln -s sccache /usr/bin/cc. By reading env::args() directly we don't have this issue. Fixes mozilla#993 Based on rivy/rs.coreutils@ad3852a
The test just looks at the output of --version instead of trying to compile anything. It does fail without Sertonix' fix in cmdline.rs, at least.
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2420 with an added comment and a test