Merged
Conversation
Contributor
Author
|
@sylvestre I took the liberty to revive #2037 to see if the situation had improved in the meantime -- not realizing I need the maintaner's approval to trigger the CI. Could you please help? |
Collaborator
|
done! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2437 +/- ##
==========================================
+ Coverage 70.78% 71.48% +0.70%
==========================================
Files 65 65
Lines 36270 36270
==========================================
+ Hits 25672 25926 +254
+ Misses 10598 10344 -254 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Thanks @sylvestre ! It looks like the job got stuck for whatever reason though... I'm quite perplexed. |
Contributor
Author
|
ok @sylvestre here's the full story
|
The image we use for building s390x does not seem to support LTO. Simply disable it at build time for s390x ONLY, by means of an extra member 'lto' of the matrix which then translates to the environment variable CARGO_PROFILE_RELEASE_LTO. This will take precedence over the setting in Cargo.toml.
sylvestre
force-pushed
the
test-s390x
branch
from
80e9981 to
cba41b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.