Skip to content

Comments

Direct mode doc fixes 3#2434

Merged
sylvestre merged 2 commits intomozilla:mainfrom
ahartmetz:direct_mode_doc_fixes_3
Aug 18, 2025
Merged

Direct mode doc fixes 3#2434
sylvestre merged 2 commits intomozilla:mainfrom
ahartmetz:direct_mode_doc_fixes_3

Conversation

@ahartmetz
Copy link
Collaborator

No description provided.

Especially what it means to hash but not cache a header, which
really makes no sense to someone without much knowledge of
implementation details. I think it's related to a cache entry
being for one source file, but containing several candidate
results distinguished by details about the headers they include.
AFAIU, there is no reason to care about that as a user because
it's always digest of various inputs (cache key) in, result or no
result out.
I think the new wording catches the gist of it.

Reference: if system && config.skip_system_headers in
remember_include_file() in c.rs and a bunch of related code.
@sylvestre sylvestre merged commit e0b192e into mozilla:main Aug 18, 2025
48 of 57 checks passed
@ahartmetz ahartmetz deleted the direct_mode_doc_fixes_3 branch September 24, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants