Fix mtime for reproducable toolchains#2430
Merged
sylvestre merged 5 commits intomozilla:mainfrom Sep 23, 2025
Merged
Conversation
Collaborator
|
could you please add a test to make sure we don't regress ? |
sylvestre
force-pushed
the
fix-mtime-in-toolchains
branch
from
4ff5271 to
b9bb613
Compare
Author
|
Yes, of course, I will. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2430 +/- ##
==========================================
+ Coverage 71.50% 71.57% +0.07%
==========================================
Files 65 65
Lines 36302 36365 +63
==========================================
+ Hits 25958 26029 +71
+ Misses 10344 10336 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Added a test, changed the solution to a more correct one during the process |
sylvestre
reviewed
Aug 18, 2025
sylvestre
reviewed
Aug 18, 2025
sylvestre
reviewed
Aug 18, 2025
Author
|
Thanks for the edits. I fixed everything. |
sylvestre
reviewed
Sep 1, 2025
sylvestre
force-pushed
the
fix-mtime-in-toolchains
branch
from
aff8605 to
7d5175f
Compare
sylvestre
force-pushed
the
fix-mtime-in-toolchains
branch
from
7d5175f to
0eb9329
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
We are running sccache-dist servers in docker and mtime in toolchains is changing, because of this new toolchains appear on the servers.
This request fixes this problem.