feat: handle human size prefixes#2405
Merged
sylvestre merged 6 commits intomozilla:mainfrom Sep 30, 2025
Merged
Conversation
iTrooz
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2405 +/- ##
==========================================
+ Coverage 70.78% 71.50% +0.72%
==========================================
Files 65 65
Lines 36270 36329 +59
==========================================
+ Hits 25672 25976 +304
+ Misses 10598 10353 -245 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iTrooz
changed the title
sylvestre
force-pushed
the
human_size
branch
from
dfe6ac4 to
0786d86
Compare
sylvestre
force-pushed
the
human_size
branch
from
9a61aa0 to
8deef0f
Compare
Collaborator
|
Any open problems here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR allows you to specify human sizes in the configuration. For example:
As a bonus, I also added for lowercase sizes, e.g. "2k"