fix: in stats, Compare values AND keys to have a fully deterministic order#2403
Merged
sylvestre merged 3 commits intomozilla:mainfrom Sep 25, 2025
Merged
fix: in stats, Compare values AND keys to have a fully deterministic order#2403sylvestre merged 3 commits intomozilla:mainfrom
sylvestre merged 3 commits intomozilla:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2403 +/- ##
==========================================
+ Coverage 71.58% 71.60% +0.01%
==========================================
Files 65 65
Lines 36372 36400 +28
==========================================
+ Hits 26037 26064 +27
- Misses 10335 10336 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iTrooz
changed the title
iTrooz
force-pushed
the
deterministic_stats
branch
from
45423c9 to
2097f0e
Compare
Collaborator
|
Could you please add a quick test to make sure we don't regress in the future? thanks |
Contributor
Author
|
Done ! Note that the test is not foolproof, because of the randomness in hashmap looping |
Contributor
Author
|
@sylvestre Hello, any news ? |
sylvestre
force-pushed
the
deterministic_stats
branch
from
97583bf to
c017362
Compare
sylvestre
force-pushed
the
deterministic_stats
branch
from
c017362 to
7834a55
Compare
sylvestre
force-pushed
the
deterministic_stats
branch
from
7834a55 to
0ca0667
Compare
tottoto
pushed a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
## Motivation The `Status` struct is the canonical error message in `tonic`. Printing it currently prints out a very verbose and difficult-to-read message. ## Solution Improve `impl, Display for status` by: * Only printing the `message` if it is non-empty * Only printing the `metadata` if it is non-empty` * Always omitting the binary `details` (printing out `details: [22, 51, 50, 48, 51, 53, 98, 57, 50, 55, 50, 55, 100, 54, 101, …]` is not helping anyone)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
watch sccache -s, the order of "Successful distributed compiles" can change randomly if two keys have the same valueThis PR fixes this