fix compilation of uds sockets on Android#2402
Closed
dead10ck wants to merge 1 commit intomozilla:mainfrom
Closed
Conversation
sylvestre
force-pushed
the
fix/android-uds
branch
from
5ede7f0 to
b331718
Compare
Author
|
Anything I can do for this PR? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2402 +/- ##
==========================================
- Coverage 71.58% 70.91% -0.67%
==========================================
Files 65 65
Lines 36214 35405 -809
==========================================
- Hits 25923 25109 -814
- Misses 10291 10296 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I just hit the same issue and made a duplicate merge request. How do we get this merged? It looks like it was hitting old unrelated CI issues on Windows... Can someone rerun CI? Or should I reopen #2442 for that purpose? |
|
@sylvestre ping and hi BTW :-) |
|
@dead10ck can you rebase this on top of current master? it'll trigger CI again |
sylvestre
force-pushed
the
fix/android-uds
branch
from
b331718 to
379c7e7
Compare
|
Done in #2442, this one can be closed now. |
tottoto
pushed a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
…ozilla#2402) ## Motivation mozilla#2360 ## Solution Added the `tls-connect-info` feature which derives from `_tls-any` feature. --------- Co-authored-by: Maple Xu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #2206, Android fails to compile, due to trying to import a Linux module. Instead, it should import the Android module.