github storage: force version 2#2385
Merged
sylvestre merged 3 commits intomozilla:mainfrom Apr 25, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2385 +/- ##
==========================================
- Coverage 65.66% 65.57% -0.10%
==========================================
Files 65 65
Lines 35496 35496
==========================================
- Hits 23310 23275 -35
- Misses 12186 12221 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Per the OpenDAL source, I think |
Collaborator
Author
|
right, thanks! |
trxcllnt
reviewed
Apr 15, 2025
| with: | ||
| script: | | ||
| core.exportVariable('ACTIONS_CACHE_URL', process.env.ACTIONS_CACHE_URL || ''); | ||
| core.exportVariable('ACTIONS_RESULTS_URL', process.env.ACTIONS_RESULTS_URL || ''); |
Contributor
There was a problem hiding this comment.
Also need to update lines 258, 542, and 602.
Collaborator
Author
There was a problem hiding this comment.
i was sure i did a full replace :(
Thanks!
trxcllnt
approved these changes
Apr 18, 2025
AJIOB
reviewed
Apr 20, 2025
| #### gha | ||
|
|
||
| * `SCCACHE_GHA_CACHE_URL` / `ACTIONS_CACHE_URL` GitHub Actions cache API URL | ||
| * `SCCACHE_GHA_CACHE_URL` / `ACTIONS_RESULTS_URL` GitHub Actions cache API URL |
Contributor
There was a problem hiding this comment.
Suggested change
| * `SCCACHE_GHA_CACHE_URL` / `ACTIONS_RESULTS_URL` GitHub Actions cache API URL | |
| * `SCCACHE_GHA_RESULTS_URL` / `ACTIONS_RESULTS_URL` GitHub Actions cache API URL |
And in the implementation, please.
IMO, they should be in sync.
AJIOB
reviewed
Apr 20, 2025
| #### gha | ||
|
|
||
| * `SCCACHE_GHA_CACHE_URL` / `ACTIONS_CACHE_URL` GitHub Actions cache API URL | ||
| * `SCCACHE_GHA_CACHE_URL` / `ACTIONS_RESULTS_URL` GitHub Actions cache API URL |
Contributor
There was a problem hiding this comment.
What about backward compatibility of the variable names? Your changes break it. Is it what you really want?
tottoto
pushed a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
Update the hello-world tutorial readme to reflect changes to package names and remove reference to deprecated tools. ## Motivation As someone relatively new to Rust and new to Tonic, I was working through the hello-world tutorial and found a few issues. I've successfully built the project with the changes in this PR. ## Solution - update example Cargo.toml to reflect package name updates - update example build.rs with correct build tool name - remove reference to deprecated GUI tool I've tested this and it runs and builds correctly. I sort of hate to reference Postman as the recommended GUI but it was the first one on the list referenced by the now-deprecated Bloom GUI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.