Improve the CARGO_INCREMENTAL checking#2364
Merged
Xuanwo merged 2 commits intomozilla:mainfrom Mar 15, 2025
Merged
Conversation
It didn't give me much hint as to what was going wrong.
We should be able to sccache --help or sccache --show-stats even if the env vars are set.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2364 +/- ##
===========================================
+ Coverage 30.91% 67.60% +36.68%
===========================================
Files 53 65 +12
Lines 20112 35471 +15359
Branches 9755 0 -9755
===========================================
+ Hits 6217 23979 +17762
- Misses 7922 11492 +3570
+ Partials 5973 0 -5973 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Xuanwo
approved these changes
Mar 15, 2025
Collaborator
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you, makes sense to me.
tottoto
pushed a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the error message to give the user a better hint of what to do in response, and make it so you can sccache --help without throwing the error.