Bail on nvcc -time and nvcc -fdevice-time-trace flags#2355
Merged
sylvestre merged 1 commit intomozilla:mainfrom Mar 7, 2025
Merged
Bail on nvcc -time and nvcc -fdevice-time-trace flags#2355sylvestre merged 1 commit intomozilla:mainfrom
nvcc -time and nvcc -fdevice-time-trace flags#2355sylvestre merged 1 commit intomozilla:mainfrom
Conversation
trxcllnt
force-pushed
the
fix/nvcc-device-time-trace
branch
from
1b7a9af to
072d426
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2355 +/- ##
===========================================
+ Coverage 30.91% 67.43% +36.51%
===========================================
Files 53 65 +12
Lines 20112 35439 +15327
Branches 9755 0 -9755
===========================================
+ Hits 6217 23897 +17680
- Misses 7922 11542 +3620
+ Partials 5973 0 -5973 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tottoto
added a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nvcc -timeandnvcc -fdevice-time-traceflags generate a csv/flamegraph to aid in debugging compilation times.This PR ensures they're parsed as
TooHard, yielding aCompileResult::CannotCache, and falling back to invokingnvccdirectly.