Skip to content

Comments

fix: Force disable "warnings as errors" flag for CL preprocessing#2251

Merged
sylvestre merged 1 commit intomozilla:mainfrom
AJIOB:AJIOB/fix-custom-warning-disabled-cl
Aug 31, 2024
Merged

fix: Force disable "warnings as errors" flag for CL preprocessing#2251
sylvestre merged 1 commit intomozilla:mainfrom
AJIOB:AJIOB/fix-custom-warning-disabled-cl

Conversation

@AJIOB
Copy link
Contributor

@AJIOB AJIOB commented Aug 31, 2024

Fix #2250

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.66%. Comparing base (0cc0c62) to head (e2d1eaf).
Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
src/compiler/msvc.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2251       +/-   ##
===========================================
+ Coverage   30.91%   51.66%   +20.74%     
===========================================
  Files          53       54        +1     
  Lines       20112    20708      +596     
  Branches     9755     9781       +26     
===========================================
+ Hits         6217    10698     +4481     
- Misses       7922     8023      +101     
+ Partials     5973     1987     -3986     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit 330d160 into mozilla:main Aug 31, 2024
@sylvestre
Copy link
Collaborator

LGTM, thanks

@AJIOB AJIOB deleted the AJIOB/fix-custom-warning-disabled-cl branch August 31, 2024 16:49
tottoto pushed a commit to tottoto/sccache that referenced this pull request Feb 6, 2026
* Expose creation of HealthService and HealthReporter

* add default impl for HealthReporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSVC: preprocessing is failed while compiling is success

3 participants