Merged
Conversation
Contributor
Author
|
CC @Xuanwo |
Contributor
Author
|
This is based on the discussion #2223 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2243 +/- ##
===========================================
+ Coverage 30.91% 51.65% +20.74%
===========================================
Files 53 55 +2
Lines 20112 20717 +605
Branches 9755 9776 +21
===========================================
+ Hits 6217 10701 +4484
- Misses 7922 8025 +103
+ Partials 5973 1991 -3982 ☔ View full report in Codecov by Sentry. |
Collaborator
|
AFAIK, it is building but not running tests, am I correct? |
Contributor
Author
|
I didn't realize there was a test step. So, I believe so. Do we want to enable testing? |
Contributor
Author
|
AFAICT, windows arm64 runners aren't available on github yet. So testing for windows arm64 isn't currently viable? |
Collaborator
|
correct but not an issue :) |
Contributor
Author
|
@sylvestre Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.