Skip to content

Comments

refactor: use windows-sys instead of winapi#2233

Merged
Xuanwo merged 1 commit intomozilla:mainfrom
Berrysoft:winapi-to-windows-sys
Jul 25, 2024
Merged

refactor: use windows-sys instead of winapi#2233
Xuanwo merged 1 commit intomozilla:mainfrom
Berrysoft:winapi-to-windows-sys

Conversation

@Berrysoft
Copy link
Contributor

Closes #2185

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM!

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.92%. Comparing base (0cc0c62) to head (f43fc14).
Report is 66 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2233       +/-   ##
===========================================
+ Coverage   30.91%   40.92%   +10.01%     
===========================================
  Files          53       55        +2     
  Lines       20112    20673      +561     
  Branches     9755     9803       +48     
===========================================
+ Hits         6217     8460     +2243     
- Misses       7922     8091      +169     
+ Partials     5973     4122     -1851     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xuanwo Xuanwo merged commit 4817844 into mozilla:main Jul 25, 2024
@Berrysoft Berrysoft deleted the winapi-to-windows-sys branch September 12, 2024 06:04
tottoto added a commit to tottoto/sccache that referenced this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate from winapi to windows-rs

3 participants