Avoid keeping lock while writing to disk cache#2193
Merged
sylvestre merged 1 commit intomozilla:mainfrom Jun 6, 2024
Merged
Conversation
This splits the insertion operation into two separate operations, so that the lock can be released while performing I/O.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2193 +/- ##
===========================================
+ Coverage 30.91% 42.77% +11.86%
===========================================
Files 53 53
Lines 20112 20412 +300
Branches 9755 9725 -30
===========================================
+ Hits 6217 8731 +2514
- Misses 7922 7982 +60
+ Partials 5973 3699 -2274 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits the insertion operation into two separate operations, so that the lock can be released while performing I/O.