Disable preprocessor cache when doing distributed compilation#2173
Merged
sylvestre merged 2 commits intomozilla:mainfrom May 21, 2024
Merged
Disable preprocessor cache when doing distributed compilation#2173sylvestre merged 2 commits intomozilla:mainfrom
sylvestre merged 2 commits intomozilla:mainfrom
Conversation
At the moment, it doesn't work.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2173 +/- ##
==========================================
- Coverage 30.91% 29.91% -1.00%
==========================================
Files 53 53
Lines 20112 20185 +73
Branches 9755 9684 -71
==========================================
- Hits 6217 6038 -179
- Misses 7922 8228 +306
+ Partials 5973 5919 -54 ☔ View full report in Codecov by Sentry. |
sylvestre
reviewed
May 17, 2024
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 7, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 7, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 7, 2025
Under the following conditions: - Build with preprocessor cache mode enabled - Distributed build - Preprocessor cache hit - Main cache miss the compile that was run as "fallback" after the cache miss did not have preprocessed sources passed to it since skipping the preprocessing step is the whole point of preprocessor cache mode. But local preprocessing is what enables distributed compilation. To fix this, when the problem occurs, recursively re-invoke get_cached_or_compile() with ForceRecache so that the preprocessor cache hit is (mostly) ignored, which makes get_cached_or_compile() invoke the local preprocessing codepath, which yields code suitable for distributed compilation.
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 7, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 7, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 7, 2025
Under the following conditions: - Build with preprocessor cache mode enabled - Distributed build - Preprocessor cache hit - Main cache miss the compile that was run as "fallback" after the cache miss did not have preprocessed sources passed to it since skipping the preprocessing step is the whole point of preprocessor cache mode. But local preprocessing is what enables distributed compilation. To fix this, when the problem occurs, recursively re-invoke get_cached_or_compile() with ForceRecache so that the preprocessor cache hit is (mostly) ignored, which makes get_cached_or_compile() invoke the local preprocessing codepath, which yields code suitable for distributed compilation.
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 7, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 7, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 7, 2025
Under the following conditions: - Build with preprocessor cache mode enabled - Distributed build - Preprocessor cache hit - Main cache miss the compile that was run as "fallback" after the cache miss did not have preprocessed sources passed to it since skipping the preprocessing step is the whole point of preprocessor cache mode. But local preprocessing is what enables distributed compilation. To fix this, when the problem occurs, recursively re-invoke get_cached_or_compile() with ForceRecache so that the preprocessor cache hit is (mostly) ignored, which makes get_cached_or_compile() invoke the local preprocessing codepath, which yields code suitable for distributed compilation.
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 7, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 7, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 7, 2025
Under the following conditions: - Build with preprocessor cache mode enabled - Distributed build - Preprocessor cache hit - Main cache miss the compile that was run as "fallback" after the cache miss did not have preprocessed sources passed to it since skipping the preprocessing step is the whole point of preprocessor cache mode. But local preprocessing is what enables distributed compilation. To fix this, when the problem occurs, recursively re-invoke get_cached_or_compile() with ForceRecache so that the preprocessor cache hit is (mostly) ignored, which makes get_cached_or_compile() invoke the local preprocessing codepath, which yields code suitable for distributed compilation.
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 8, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 8, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 8, 2025
Under the following conditions: - Build with preprocessor cache mode enabled - Distributed build - Preprocessor cache hit - Main cache miss the compile that was run as "fallback" after the cache miss did not have preprocessed sources passed to it since skipping the preprocessing step is the whole point of preprocessor cache mode. But local preprocessing is what enables distributed compilation. To fix this, when the problem occurs, recursively re-invoke get_cached_or_compile() with ForceRecache so that the preprocessor cache hit is (mostly) ignored, which makes get_cached_or_compile() invoke the local preprocessing codepath, which yields code suitable for distributed compilation.
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 8, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 8, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 8, 2025
Under the following conditions: - Build with preprocessor cache mode enabled - Distributed build - Preprocessor cache hit - Main cache miss the compile that was run as "fallback" after the cache miss did not have preprocessed sources passed to it since skipping the preprocessing step is the whole point of preprocessor cache mode. But local preprocessing is what enables distributed compilation. To fix this, when the problem occurs, recursively re-invoke get_cached_or_compile() with ForceRecache so that the preprocessor cache hit is (mostly) ignored, which makes get_cached_or_compile() invoke the local preprocessing codepath, which yields code suitable for distributed compilation.
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 9, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 9, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 9, 2025
Under the following conditions: - Build with preprocessor cache mode enabled - Distributed build - Preprocessor cache hit - Main cache miss the compile that was run as "fallback" after the cache miss did not have preprocessed sources passed to it since skipping the preprocessing step is the whole point of preprocessor cache mode. But local preprocessing is what enables distributed compilation. To fix this, when the problem occurs, recursively re-invoke get_cached_or_compile() with ForceRecache so that the preprocessor cache hit is (mostly) ignored, which makes get_cached_or_compile() invoke the local preprocessing codepath, which yields code suitable for distributed compilation.
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 9, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 9, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 9, 2025
Under the following conditions: - Build with preprocessor cache mode enabled - Distributed build - Preprocessor cache hit - Main cache miss the compile that was run as "fallback" after the cache miss did not have preprocessed sources passed to it since skipping the preprocessing step is the whole point of preprocessor cache mode. But local preprocessing is what enables distributed compilation. To fix this, when the problem occurs, recursively re-invoke get_cached_or_compile() with ForceRecache so that the preprocessor cache hit is (mostly) ignored, which makes get_cached_or_compile() invoke the local preprocessing codepath, which yields code suitable for distributed compilation.
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 9, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 9, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 9, 2025
Under the following conditions: - Build with preprocessor cache mode enabled - Distributed build - Preprocessor cache hit - Main cache miss the compile that was run as "fallback" after the cache miss did not have preprocessed sources passed to it since skipping the preprocessing step is the whole point of preprocessor cache mode. But local preprocessing is what enables distributed compilation. To fix this, when the problem occurs, recursively re-invoke get_cached_or_compile() with ForceRecache so that the preprocessor cache hit is (mostly) ignored, which makes get_cached_or_compile() invoke the local preprocessing codepath, which yields code suitable for distributed compilation.
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 9, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 9, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 9, 2025
Under the following conditions: - Build with preprocessor cache mode enabled - Distributed build - Preprocessor cache hit - Main cache miss the compile that was run as "fallback" after the cache miss did not have preprocessed sources passed to it since skipping the preprocessing step is the whole point of preprocessor cache mode. But local preprocessing is what enables distributed compilation. To fix this, when the problem occurs, recursively re-invoke get_cached_or_compile() with ForceRecache so that the preprocessor cache hit is (mostly) ignored, which makes get_cached_or_compile() invoke the local preprocessing codepath, which yields code suitable for distributed compilation.
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 11, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 11, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Jul 11, 2025
Under the following conditions: - Build with preprocessor cache mode enabled - Distributed build - Preprocessor cache hit - Main cache miss the compile that was run as "fallback" after the cache miss did not have preprocessed sources passed to it since skipping the preprocessing step is the whole point of preprocessor cache mode. But local preprocessing is what enables distributed compilation. To fix this, when the problem occurs, recursively re-invoke get_cached_or_compile() with ForceRecache so that the preprocessor cache hit is (mostly) ignored, which makes get_cached_or_compile() invoke the local preprocessing codepath, which yields code suitable for distributed compilation.
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Aug 4, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Aug 4, 2025
ahartmetz
added a commit
to ahartmetz/sccache
that referenced
this pull request
Aug 4, 2025
Under the following conditions: - Build with preprocessor cache mode enabled - Distributed build - Preprocessor cache hit - Main cache miss the compile that was run as "fallback" after the cache miss did not have preprocessed sources passed to it since skipping the preprocessing step is the whole point of preprocessor cache mode. But local preprocessing is what enables distributed compilation. To fix this, when the problem occurs, recursively re-invoke get_cached_or_compile() with ForceRecache so that the preprocessor cache hit is (mostly) ignored, which makes get_cached_or_compile() invoke the local preprocessing codepath, which yields code suitable for distributed compilation.
sylvestre
pushed a commit
that referenced
this pull request
Aug 4, 2025
sylvestre
pushed a commit
that referenced
this pull request
Aug 4, 2025
sylvestre
pushed a commit
that referenced
this pull request
Aug 4, 2025
Under the following conditions: - Build with preprocessor cache mode enabled - Distributed build - Preprocessor cache hit - Main cache miss the compile that was run as "fallback" after the cache miss did not have preprocessed sources passed to it since skipping the preprocessing step is the whole point of preprocessor cache mode. But local preprocessing is what enables distributed compilation. To fix this, when the problem occurs, recursively re-invoke get_cached_or_compile() with ForceRecache so that the preprocessor cache hit is (mostly) ignored, which makes get_cached_or_compile() invoke the local preprocessing codepath, which yields code suitable for distributed compilation.
tottoto
added a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, it doesn't work.