hmm. i'll have to fix this import issue.

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 30.49%. Comparing base (0cc0c62) to head (d9251b6).
Report is 16 commits behind head on main.

❗ Current head d9251b6 differs from pull request most recent head 96f7ed2. Consider uploading reports for the commit 96f7ed2 to get more accurate results

@@            Coverage Diff             @@
##             main    #2137      +/-   ##
==========================================
- Coverage   30.91%   30.49%   -0.42%     
==========================================
  Files          53       53              
  Lines       20112    20486     +374     
  Branches     9755     9954     +199     
==========================================
+ Hits         6217     6248      +31     
- Misses       7922     8189     +267     
- Partials     5973     6049      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cc @sylvestre, would you like to take another look?

thanks

@ajschmidt8 , just for note: do this really works in the prebuilt binary automatically (if you run the binary without cargo run)? Or we always need to define these Cargo variables externally?

@ajschmidt8 , just for note: do this really works in the prebuilt binary automatically (if you run the binary without cargo run)? Or we always need to define these Cargo variables externally?

rust's env! macro captures environment variables at compile time: https://doc.rust-lang.org/std/macro.env.html.

and Cargo sets these values at compile time.

so they won't need to be defined externally. it will work in the prebuilt binary automatically.

@AJIOB, just curious. do you intend to use this feature? if so, what's your use case?

No, I just confused about backward compatibility with existing usages of S3 backend.