Skip to content

Comments

rustc driver detection - includes #1897#2085

Merged
sylvestre merged 2 commits intomainfrom
bernhard-rustc-better
Feb 23, 2024
Merged

rustc driver detection - includes #1897#2085
sylvestre merged 2 commits intomainfrom
bernhard-rustc-better

Conversation

@drahnr
Copy link
Collaborator

@drahnr drahnr commented Feb 12, 2024 •
edited
Loading

If we are not sure it's rustc like and we check -vV output to accept valid rustc drivers. Simplifies #1897 .

Fixes #861

@drahnr drahnr requested review from Xanewok and sylvestre February 12, 2024 12:12
@drahnr drahnr changed the title Follow up on #1897 rustc driver detection - follow up on #1897 Feb 12, 2024
@sylvestre
Copy link
Collaborator

sylvestre commented Feb 13, 2024

It would be nice to update the commit to explicit why we are doing it

@drahnr
Copy link
Collaborator Author

drahnr commented Feb 20, 2024 •
edited
Loading

It would be nice to update the commit to explicit why we are doing it

The commit or the PR desc? Squash merge 'd be fine by me.

@sylvestre
Copy link
Collaborator

sylvestre commented Feb 20, 2024

The commit please

@drahnr drahnr force-pushed the bernhard-rustc-better branch 2 times, most recently from de6aa41 to cbe79c9 Compare February 22, 2024 18:32
@drahnr
Copy link
Collaborator Author

drahnr commented Feb 22, 2024

Is the above sufficient @sylvestre ? I'd still be in favor of squash this PR, left the two commits separate for no particular reason other than authorship

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: 127 lines in your changes are missing coverage. Please review.

Comparison is base (ffe3070) 30.77% compared to head (cbe79c9) 32.17%.
Report is 19 commits behind head on main.

Files Patch % Lines
src/compiler/compiler.rs 31.69% 17 Missing and 108 partials ⚠️
src/test/tests.rs 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2085      +/-   ##
==========================================
+ Coverage   30.77%   32.17%   +1.40%     
==========================================
  Files          52       53       +1     
  Lines       19913    20721     +808     
  Branches     9630    10296     +666     
==========================================
+ Hits         6129     6668     +539     
+ Misses       7959     7877      -82     
- Partials     5825     6176     +351

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drahnr drahnr force-pushed the bernhard-rustc-better branch from cbe79c9 to 9701f53 Compare February 22, 2024 19:20
@drahnr drahnr changed the title rustc driver detection - follow up on #1897 rustc driver detection - includes #1897 Feb 22, 2024
@drahnr
Copy link
Collaborator Author

drahnr commented Feb 23, 2024 •
edited
Loading

The coverage report is obsolete, it actually improved marginally.

CC @sylvestre anything missing/insufficient, otherwise I'd merge with rebase?

@sylvestre sylvestre merged commit 0cc0c62 into main Feb 23, 2024
@sylvestre sylvestre deleted the bernhard-rustc-better branch February 23, 2024 17:15
tottoto added a commit to tottoto/sccache that referenced this pull request Feb 6, 2026
@tottoto
chore(web): Remove converting to same type (mozilla#2085)
9606c5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

@Xanewok Xanewok Awaiting requested review from Xanewok

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support arbitrary rustc drivers

4 participants

@drahnr @sylvestre @codecov-commenter @sagudev