feat: Add possibility to configure key prefix (Redis, MemCached)#2084
Merged
sylvestre merged 6 commits intomozilla:mainfrom Feb 15, 2024
Merged
feat: Add possibility to configure key prefix (Redis, MemCached)#2084sylvestre merged 6 commits intomozilla:mainfrom
sylvestre merged 6 commits intomozilla:mainfrom
Conversation
Contributor
AJIOB
commented
Feb 11, 2024
AJIOB
commented
- Add possibility to configure key prefix for Redis & MemCached
- Unify Redis & MemCached expiraction time
- Actualize configuration docs
* Fix config values loading for memcached & redis
AJIOB
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2084 +/- ##
==========================================
- Coverage 30.77% 30.70% -0.08%
==========================================
Files 52 52
Lines 19913 19944 +31
Branches 9630 9658 +28
==========================================
- Hits 6129 6123 -6
- Misses 7959 7990 +31
- Partials 5825 5831 +6 ☔ View full report in Codecov by Sentry. |
Collaborator
|
if i understand correctly this PR, it isn't going to change the behavior of existing configurations, right? |
Contributor
Author
|
@sylvestre, yes, you are right. I am not changed the current configuration API. Just documenting, unifying & extending it. |
AJIOB
changed the title
AJIOB
changed the title
Contributor
Author
|
@Xuanwo, hello. What I need to do for merging this PR? Do we have some problems with this changes? Or I need to split it to few ones? |
Collaborator
|
Those changes LGTM! cc @sylvestre do you want to take another look? |
Collaborator
|
thanks! |
tottoto
added a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.