fix(src/compiler/c): take common_args into account during preprocessor hashing#2039
Merged
Xuanwo merged 1 commit intomozilla:mainfrom Jan 18, 2024
Merged
Conversation
Collaborator
|
Could you please add a test to make sure we don't regress? Thanks |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2039 +/- ##
==========================================
+ Coverage 30.71% 31.00% +0.28%
==========================================
Files 51 51
Lines 19604 19653 +49
Branches 9422 9452 +30
==========================================
+ Hits 6022 6094 +72
+ Misses 7861 7853 -8
+ Partials 5721 5706 -15 ☔ View full report in Codecov by Sentry. |
GZGavinZhao
force-pushed
the
fix-preprocessor-cache
branch
from
f9ac3d0 to
189d0cf
Compare
Contributor
Author
|
@sylvestre Added a test case. Would this be enough? |
GZGavinZhao
force-pushed
the
fix-preprocessor-cache
branch
from
189d0cf to
4d5267b
Compare
Contributor
Author
|
Addressed lints. |
…r hashing Signed-off-by: Gavin Zhao <[email protected]>
sylvestre
force-pushed
the
fix-preprocessor-cache
branch
from
4d5267b to
e9e0d1e
Compare
Contributor
Author
|
Would someone mind merging this? IMO this is a pretty serious issue, because |
1 task
glandium
reviewed
Feb 9, 2024
| let mut preprocessor_and_arch_args = parsed_args.preprocessor_args.clone(); | ||
| preprocessor_and_arch_args.extend(parsed_args.arch_args.to_vec()); | ||
| // common_args is used in preprocessing too | ||
| preprocessor_and_arch_args.extend(parsed_args.common_args.to_vec()); |
Collaborator
There was a problem hiding this comment.
Removing this line doesn't make the test fail.
tottoto
added a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2038.
Since
common_argsrepresents the flags that are used both for compilation and for preprocessing, during preprocessor cachingcommon_argsshould be taken into account as well.