Conversation
jasonwhite
force-pushed
the
msvc-response-files
branch
from
231e6d3 to
c50b787
Compare
jasonwhite
force-pushed
the
msvc-response-files
branch
from
220eeb2 to
7cc4dd8
Compare
|
I fixed a few problems in my implementation:
I'm more confident that this implementation is solid now, but a code review would be great. |
jasonwhite
force-pushed
the
msvc-response-files
branch
from
67d7fae to
c3f6596
Compare
|
@luser Could you review this when you have a chance? I'm not in a rush, but it'd be nice to get this in before it rots for too long. I'll follow up with another pull request to add support for multiple inputs per command line. It'll be a while before that part is done though. |
|
Hi all! Any chance the above PR will be accepted/rejected sometime soon? I've been attempting to leverage |
MSBuild passes them to the response file this way.
If a directory is specified with `-Fo`, it should be interpretted as the base directory for object files. The path to the object file is then the directory + the basename of the source file with an `.obj` extension. https://docs.microsoft.com/en-us/cpp/build/reference/fo-object-file-name
jasonwhite
force-pushed
the
msvc-response-files
branch
from
aaaa576 to
03a345d
Compare
|
I rebased to resolve the merge conflict. This is good to go. |
|
Hi again, Is this one projected to merge sometime soon? |
|
Sorry, this is just large enough that I need to clear headspace to review it and I haven't managed. |
|
|
||
| Instead, you must use `/Z7` where the debug information is embedded in the | ||
| object file itself. The main trade off is that you cannot use Minimal Rebuild | ||
| (`/Gm`) or Edit and Continue. |
There was a problem hiding this comment.
Also consider the /Fd option to name your PDB file. When you compile a single input and write to an exclusiv PDB file, explicitly named with /Fd compilation, hashing and caching is safe.
|
@jasonwhite, do you have space/time to rebase this? |
|
Closing this as I currently don't use sccache. I may come back to this in the future, but someone else is free to pick this back up where I left off. |
Adds an iteration layer between the command-line argument iterator and the `ArgIter` used to compare arguments against the supported flags/options. This new layer determines if an option is a response-file directive (`@file`), and if it is, reads the options from the file before continuing to iterate over the command-line args. This requires an additional file-parsing iterating (`SplitArgs`) to split the file contents into arguments in a way which is consistent with the file format. The `encoding` crate is used to read utf-8 (default encoding in rust) & utf-16 (big and little endian) encodings. The latter is used by `MSBuild` when generating response files. Resources: - [MSDN](https://docs.microsoft.com/en-us/cpp/build/reference/at-specify-a-compiler-response-file) - [MSBuild](https://learn.microsoft.com/en-us/visualstudio/msbuild/msbuild-response-files?view=vs-2019) Contributes to #107 Based off of #192 Closes #1082 Closes #1183
b90c340 (feat(transport): Allow custom IO and UDS example (mozilla#184), 2019-12-13) changed the Connector type to be more generic instead of only allowing the HttpConnector type, during this change the `Service::poll_ready` impl was changed from calling `MakeConnection::poll_ready` on `self.http` to `self` resulting in infinite recursion due to the blanket imple of `MakeConnection::poll_ready` calling `Service::poll_ready`. This fixes the bug by calling `MakeConnection::poll_ready` on `self.inner` instead of `self`. Fixes mozilla#191
5 participants
Adds support for
@-files appearing on the MSVC command line.The response file is expanded in-place on the command line, but not recursively like in the gcc implementation in order to conform to the spec. I also implemented a Windows command line parser for this instead of relying on
CommandLineToArgvWjust in case people somehow use the MSVC compiler on non-Windows platforms.This was one of the blockers for MSBuild support as mentioned in #107 (comment). After this is merged, I'll look into adding support for handling multiple source files on one command line.
Please rip it apart in a code review.