sccache fails to build on non x86_64/aarch64 arches#1866
Merged
sylvestre merged 1 commit intomozilla:mainfrom Sep 7, 2023
Merged
sccache fails to build on non x86_64/aarch64 arches#1866sylvestre merged 1 commit intomozilla:mainfrom
sylvestre merged 1 commit intomozilla:mainfrom
Conversation
On all arches except x86_64/aarch64 sccache fails to build. This is due to the use of rustls/ring as a feature in trust-dns-resolver. However, trust dns resolver isn't actually needed when you set --no-default-features, since this appears to only be to coerce features in trust-dns-resolver when reqwest is present. As a result, trust-dns-resolver should be optional and only added when required.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
==========================================
+ Coverage 29.46% 29.55% +0.08%
==========================================
Files 49 49
Lines 17844 17844
Branches 8631 8631
==========================================
+ Hits 5257 5273 +16
- Misses 7347 7350 +3
+ Partials 5240 5221 -19 ☔ View full report in Codecov by Sentry. |
tottoto
pushed a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
…onnect` code (mozilla#1866) * tls feature flag for Endpoint::new * added unit test * Simplified `Endpoint::new` initialization
tottoto
pushed a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
* fix: tls config overwrite in endpoint PR mozilla#1866 fixed the breaking change introduced in mozilla#1731, but resets the TLS config without checking if `tls` is set. This patch resolves the regression and restores expected behaviour. * fix: cargo fmt whitespace check --------- Co-authored-by: vigneshwar.sm <[email protected]> Co-authored-by: Lucio Franco <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On all arches except x86_64/aarch64 sccache fails to build. This is due to the use of rustls/ring as a feature in trust-dns-resolver.
However, trust dns resolver isn't actually needed when you set --no-default-features, since this appears to only be to coerce features in trust-dns-resolver when reqwest is present.
As a result, trust-dns-resolver should be optional and only added when required.