msvc: fix detect_showincludes_prefix when VS_UNICODE_OUTPUT is set#1835
Closed
AudranDoublet wants to merge 1 commit intomozilla:mainfrom
Closed
msvc: fix detect_showincludes_prefix when VS_UNICODE_OUTPUT is set#1835AudranDoublet wants to merge 1 commit intomozilla:mainfrom
AudranDoublet wants to merge 1 commit intomozilla:mainfrom
Conversation
AudranDoublet
commented
Jul 21, 2023
| // The MSDN docs say the -showIncludes output goes to stderr, | ||
| // but that's not true unless running with -E. | ||
| .stdout(Stdio::piped()) | ||
| .stderr(Stdio::null()); |
Contributor
Author
There was a problem hiding this comment.
removed as run_input_output override these values
sylvestre
force-pushed
the
bug/msvc/detect-showIncludes-fail_VS_UNICODE_OUTPUT
branch
from
0c7f247 to
c9cf42a
Compare
sylvestre
force-pushed
the
bug/msvc/detect-showIncludes-fail_VS_UNICODE_OUTPUT
branch
from
c9cf42a to
5560f1d
Compare
Collaborator
|
many jobs are failing to build |
|
Is there any update on this, I tried to run this locally(based of 0.8.0 release) and the error went away, but it seems that sccache didn't attempt to do any caching |
Contributor
|
Such a shame this got closed. @AudranDoublet would you mind if I attempt to shape up your changes and adjust them to the latest version of PS: not much adjustment was required. Rebase worked, now checking regarding tests and so on. |
AJIOB
pushed a commit
to AJIOB/sccache
that referenced
this pull request
Jan 8, 2026
The problem usually occurs when VS_UNICODE_OUTPUT is set. This is a @AudranDoublet mozilla#1835 and @exoosh mozilla#2483 fixes with working tests: thank you! Should fix issues mozilla#1830 and mozilla#909
AJIOB
pushed a commit
to AJIOB/sccache
that referenced
this pull request
Jan 8, 2026
The problem usually occurs when VS_UNICODE_OUTPUT is set. This is a @AudranDoublet mozilla#1835 and @exoosh mozilla#2483 fixes with working tests: thank you! Should fix issues mozilla#1830 and mozilla#909
AJIOB
pushed a commit
to AJIOB/sccache
that referenced
this pull request
Jan 12, 2026
The problem usually occurs when VS_UNICODE_OUTPUT is set. This is a @AudranDoublet mozilla#1835 and @exoosh mozilla#2483 fixes with working tests: thank you! Should fix issues mozilla#1830 and mozilla#909
AJIOB
pushed a commit
to AJIOB/sccache
that referenced
this pull request
Jan 13, 2026
The problem usually occurs when VS_UNICODE_OUTPUT is set. This is a @AudranDoublet mozilla#1835 and @exoosh mozilla#2483 fixes with working tests: thank you! Should fix issues mozilla#1830 and mozilla#909
AJIOB
pushed a commit
to AJIOB/sccache
that referenced
this pull request
Jan 13, 2026
The problem usually occurs when VS_UNICODE_OUTPUT is set. This is a @AudranDoublet mozilla#1835 and @exoosh mozilla#2483 fixes with working tests: thank you! Should fix issues mozilla#1830 and mozilla#909
tottoto
pushed a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
There is a bug such that if the client sends a response with a header value that exceeds the max_header_list_size, then RPCs just hang (mozilla#1834). When tonic upgraded to hyper 1, it picked up [hyper#3622] which changed the default from 16MiB to 16KiB for this configuration value. Error messages in gRPC use headers. That means that services which ever sent error messages in excess of 16KiB (including in their error details!) will just hang. This commit adds the ability for the client to configure this value to something larger (perhaps the old default of 16MiB) to mitigate the above-referenced bug. [hyper#3622]: hyperium/hyper#3622
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VS_UNICODE_OUTPUTis set by Visual Studio to a value that tells MS tools running from within the IDE where to send their output. Thus,cl.exeinvocation used to retrieve the/showIncludesprefix returns an empty output when this variable is set to a valid value.The proposed fix is to use
/Eoption that tellscl.exeto output file content in stdout and retrieved headers in stderr. When set,cl.exeignores the value ofVS_UNICODE_OUTPUT.Another fix could be to explicitly unset
VS_UNICODE_OUTPUTin the command invocation.#1830 #909 mentioning these issues as it may fix them.