msvc: passthrough argument -Qpar-#1834
Merged
sylvestre merged 1 commit intomozilla:mainfrom Apr 30, 2024
Merged
Conversation
sylvestre
force-pushed
the
feature/msvc/support-qpar-
branch
from
6fd928a to
e8213e8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1834 +/- ##
==========================================
+ Coverage 30.81% 30.87% +0.05%
==========================================
Files 53 53
Lines 20014 20014
Branches 9700 9700
==========================================
+ Hits 6168 6179 +11
+ Misses 7926 7923 -3
+ Partials 5920 5912 -8 ☔ View full report in Codecov by Sentry. |
sylvestre
force-pushed
the
feature/msvc/support-qpar-
branch
from
e8213e8 to
ce07fbb
Compare
sylvestre
force-pushed
the
feature/msvc/support-qpar-
branch
from
ce07fbb to
8709030
Compare
Collaborator
|
Could you please add a test ? thanks |
Contributor
|
Hi, @sylvestre Or you want anything else? |
Contributor
|
Hi @Xuanwo. Looks like the PR is ready, isn't it? |
tottoto
pushed a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
There is a bug such that if the client sends a response with a header value that exceeds the max_header_list_size, then RPCs just hang (mozilla#1834). When tonic upgraded to hyper 1, it picked up [hyper#3622] which changed the default from 16MiB to 16KiB for this configuration value. Error messages in gRPC use headers. That means that services which ever sent error messages in excess of 16KiB (including in their error details!) will just hang. This commit adds the ability for the client to configure this value to something larger (perhaps the old default of 16MiB) to mitigate the above-referenced bug. [hyper#3622]: hyperium/hyper#3622
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/Qpar-is set by MsBuild whenEnableParallelCodeGenerationis explicitly set tofalse.Current code is considering it as a file name, thus the command is considered as non-cacheable (multiple input file).